[webkit-reviews] review requested: [Bug 109591] Fix hasOutOfFlowPositionedDescendant : [Attachment 196250] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 16:29:55 PDT 2013


vollick at chromium.org has asked	for review:
Bug 109591: Fix hasOutOfFlowPositionedDescendant
https://bugs.webkit.org/show_bug.cgi?id=109591

Attachment 196250: Patch
https://bugs.webkit.org/attachment.cgi?id=196250&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #6)
> Is this all really worth the benefit?

Ack, I'm sorry. I think I misunderstood you. I think you were asking if all of
these optimizations were really worth the benefit. Turns out they weren't. I
went ahead and implemented them, but I found that even with the naive approach,
we only spend about 0.3ms in ::hasOutOfFlowPositionedDescendant while loading
gmail on my desktop machine. This simplifies things a lot.

This patch includes the changes for 109966. It doesn't perform correctly
without
the fixes in that patch.


More information about the webkit-reviews mailing list