[webkit-reviews] review granted: [Bug 113821] [GTK] Make libsecret optional : [Attachment 196215] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 113821: [GTK] Make libsecret optional
https://bugs.webkit.org/show_bug.cgi?id=113821

Attachment 196215: Patch
https://bugs.webkit.org/attachment.cgi?id=196215&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196215&action=review


> Source/autotools/ReadCommandLineArguments.m4:69
> +    [AS_HELP_STRING([--enable-credential-storage],[enable support for
credential storage (introduces a dependency on libsecret)])],

Missing information on the default. Are you using 'credential-storage-' to get
the option automatically mapped from build-webkit? Otherwise I think it may be
simpler/easier to understand to use enable-libsecret, I trust your call, anyway
=).