[webkit-reviews] review granted: [Bug 113779] Web Inspector: [Mac/WK1] Provide way to disable docking for the Web Inspector : [Attachment 196130] Proposed Change

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 113779: Web Inspector: [Mac/WK1] Provide way to disable docking for the Web
Inspector
https://bugs.webkit.org/show_bug.cgi?id=113779

Attachment 196130: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=196130&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196130&action=review


> Source/WebKit/cf/ChangeLog:5
> +	   The user default is "WebKit Web Inspector Setting -
inspectorAttachDisabled".

This seems good for now. Ideally this could be set, per-WebInspector.

> Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp:110
> +    storeSetting(inspectorAttachDisabledSetting, disabled ? "true" :
"false");

These could be ASCIILiteral("true") and ASCIILiteral("false") (fast path String
construction from literals).