[webkit-reviews] review denied: [Bug 113713] [WK2] WebPageProxy's setViewNeedsDisplay() and viewSize() should check page validity. : [Attachment 196002] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 2 11:22:47 PDT 2013
Benjamin Poulain <benjamin at webkit.org> has denied Marcelo Lira
<marcelo.lira at openbossa.org>'s request for review:
Bug 113713: [WK2] WebPageProxy's setViewNeedsDisplay() and viewSize() should
check page validity.
https://bugs.webkit.org/show_bug.cgi?id=113713
Attachment 196002: Patch
https://bugs.webkit.org/attachment.cgi?id=196002&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196002&action=review
> Source/WebKit2/ChangeLog:4
> + WebPageProxy's setViewNeedsDisplay() and viewSize() should check
page validity.
> + https://bugs.webkit.org/show_bug.cgi?id=113713
No they shouldn't.
You must explain _why_ the change is needed. And add a test unless you have a
good reason.
More information about the webkit-reviews
mailing list