[webkit-reviews] review granted: [Bug 112967] Touch dragging should not send fake mouse down event as webapps may misinterpret it : [Attachment 195376] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Apr 2 11:18:50 PDT 2013
Antonio Gomes <tonikitoo at webkit.org> has granted Varun Jain
<varunjain at chromium.org>'s request for review:
Bug 112967: Touch dragging should not send fake mouse down event as webapps may
misinterpret it
https://bugs.webkit.org/show_bug.cgi?id=112967
Attachment 195376: Patch
https://bugs.webkit.org/attachment.cgi?id=195376&action=review
------- Additional Comments from Antonio Gomes <tonikitoo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195376&action=review
> Source/WebCore/page/EventHandler.cpp:2612
> + if (subframe &&
subframe->eventHandler()->handleGestureLongPress(gestureEvent))
> + return true;
> + m_mouseDownMayStartDrag = true;
> + dragState().m_dragSrc = 0;
> + TemporaryChange<IntPoint> mouseDown(m_mouseDownPos,
m_frame->view()->windowToContents(mouseDragEvent.position()));
Please add a test for this change as well.
More information about the webkit-reviews
mailing list