[webkit-reviews] review denied: [Bug 113670] Web Inspector: manually update local variable in UI after its value was changed : [Attachment 196142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 11:16:34 PDT 2013


Pavel Feldman <pfeldman at chromium.org> has denied Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 113670: Web Inspector: manually update local variable in UI after its value
was changed
https://bugs.webkit.org/show_bug.cgi?id=113670

Attachment 196142: Patch
https://bugs.webkit.org/attachment.cgi?id=196142&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196142&action=review


> Source/WebCore/inspector/front-end/RemoteObject.js:185
> +    getPropertiesImpl: function(ownProperties, callback)

We typically say doGetProperties

> Source/WebCore/inspector/front-end/RemoteObject.js:191
> +	   

Extra space

> Source/WebCore/inspector/front-end/RemoteObject.js:389
> + * @param {WebInspector.ScopeRef=} scopeRef

Why is this optional?

> Source/WebCore/inspector/front-end/RemoteObject.js:450
> +	      
WebInspector.RemoteObject.prototype.setObjectPropertyValueImpl.call(this,
result, name, callback);

When do we get here and why?


More information about the webkit-reviews mailing list