[webkit-reviews] review denied: [Bug 109579] [CoordGfx] Speed up web process rendering with double buffering : [Attachment 196150] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 10:22:39 PDT 2013


Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 109579: [CoordGfx] Speed up web process rendering with double buffering
https://bugs.webkit.org/show_bug.cgi?id=109579

Attachment 196150: Patch
https://bugs.webkit.org/attachment.cgi?id=196150&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196150&action=review


>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.
cpp:291
> +    ASSERT(m_waitingForUIProcess || !m_shouldSyncFrame);
> +    return !m_shouldSyncFrame;

r- following the m_shouldSyncFrame vs. m_hasPrerenderedFrame comment before.
They aren't the same (they were set to false in the same conditions, but not to
true).


More information about the webkit-reviews mailing list