[webkit-reviews] review granted: [Bug 113797] [Skia] Enable GPU-accelerated Skia path for FEComposite filter. : [Attachment 196163] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 113797: [Skia] Enable GPU-accelerated Skia path for FEComposite filter.
https://bugs.webkit.org/show_bug.cgi?id=113797

Attachment 196163: Patch
https://bugs.webkit.org/attachment.cgi?id=196163&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196163&action=review


R=me, with a few nits.

> Source/WebCore/platform/graphics/filters/skia/FECompositeSkia.cpp:82
> +    typedef SkImageFilter INHERITED;

As a drive-by style comment, defining INHERITED looks a little odd to my eyes.

>
LayoutTests/platform/chromium-linux/css3/filters/effect-reference-composite-exp
ected.txt:1
> +layer at (0,0) size 800x600

Is there a reason to have a text dump on either of these tests? They seem
entirely like pixel tests.