[webkit-reviews] review granted: [Bug 113746] WebKit/mac shouldn't have code for Mac 10.5 and earlier : [Attachment 196077] Fixed per Mark's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 09:47:13 PDT 2013


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 113746: WebKit/mac shouldn't have code for Mac 10.5 and earlier
https://bugs.webkit.org/show_bug.cgi?id=113746

Attachment 196077: Fixed per Mark's comments
https://bugs.webkit.org/attachment.cgi?id=196077&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196077&action=review


> Source/WebKit/mac/WebView/WebView.mm:1472
> +    settings->setNeedsLeopardMailQuirks(false);

I don’t think we need this line at all. This defaults to false and we will
never set it to true. So please delete this.

In fact, as a followup we could remove this setting from WebCore entirely.


More information about the webkit-reviews mailing list