[webkit-reviews] review denied: [Bug 93965] [CSS Regions] Region.regionOverset and visual overflow are incorrectly computed when content in the named flow is relatively positioned : [Attachment 191693] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 93965: [CSS Regions] Region.regionOverset and visual overflow are
incorrectly computed when content in the named flow is relatively positioned
https://bugs.webkit.org/show_bug.cgi?id=93965

Attachment 191693: Patch
https://bugs.webkit.org/attachment.cgi?id=191693&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191693&action=review


> Source/WebCore/rendering/RenderBox.cpp:4076
> -    if (child->hasSelfPaintingLayer() || hasOverflowClip())
> +    RenderFlowThread* flowThread = flowThreadContainingBlock();
> +    if ((child->hasSelfPaintingLayer() && !flowThread) || hasOverflowClip())


This is not correct. You should never ever propagate visual overflow across a
self-painting layer boundary.