[webkit-reviews] review granted: [Bug 113720] AX: Need to get line thickness from fraction on web : [Attachment 196025] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Apr 2 08:49:44 PDT 2013


David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 113720: AX: Need to get line thickness from fraction on web
https://bugs.webkit.org/show_bug.cgi?id=113720

Attachment 196025: patch 
https://bugs.webkit.org/attachment.cgi?id=196025&action=review

------- Additional Comments from David Kilzer (:ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196025&action=review


r=me

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:2008
> +- (NSInteger)accessibilityMathLineThickness
> +{
> +    if (![self _prepareAccessibilityCall])
> +	   return 0;

I don't see this check added to some of the -accessibilityMath* methods above.

Is it necessary?  Should all of the methods above have this check as well?


More information about the webkit-reviews mailing list