[webkit-reviews] review denied: [Bug 113639] assignToHTMLImageElement no longer exists in Qt5 : [Attachment 195855] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has denied Kristof Provost
<kristof at sigsegv.be>'s request for review:
Bug 113639: assignToHTMLImageElement no longer exists in Qt5
https://bugs.webkit.org/show_bug.cgi?id=113639

Attachment 195855: Patch
https://bugs.webkit.org/attachment.cgi?id=195855&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195855&action=review


> Source/WebCore/ChangeLog:3
> +	   assignToHTMLImageElement no longer exists in Qt5

We usually add a [Qt] prefix before the titles and ChangeLog headlines of
Qt-specific WebKit bugs.

> Source/WebCore/bridge/qt/qt_pixmapruntime.cpp:257
> +	   { "assignToHTMLImageElement", assignToHTMLImageElement, 0 },
>	   { "assignTo", assignToHTMLImageElement, 0 },

This was a mistake so I think that we can just replace the "assignTo" entry
instead of having two names for the function.