[webkit-reviews] review denied: [Bug 110314] [GTK][AC] Implement matrix keyframe animations with clutter ac backend : [Attachment 189267] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 110314: [GTK][AC] Implement matrix keyframe animations with clutter ac
backend
https://bugs.webkit.org/show_bug.cgi?id=110314

Attachment 189267: Patch
https://bugs.webkit.org/attachment.cgi?id=189267&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=189267&action=review


> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:540
> +    GOwnPtr<GValue> keyValues(g_new0(GValue, nKeyframes));

This will go wrong. GOwnPtr will expect a single GValue pointer here but you
want an array. We either need a GOwnArrayPtr like the one used for OwnPtr
above, or manual handling of this array. I suggest using manual handling.

> Source/WebCore/platform/graphics/clutter/PlatformClutterAnimation.cpp:559
> +    for (unsigned i = 0; i < nKeyframes; ++i)
> +	   g_value_unset(&keyValues.get()[i]);
> +}

Then here you'll have to free all of the values instead of unsetting.