[webkit-reviews] review denied: [Bug 111198] Web Inspector: feature request save/load CPU profile : [Attachment 195976] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 111198: Web Inspector: feature request save/load CPU profile
https://bugs.webkit.org/show_bug.cgi?id=111198

Attachment 195976: Patch
https://bugs.webkit.org/attachment.cgi?id=195976&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195976&action=review


Can we test this code?

> Source/WebCore/ChangeLog:10
> +	   So I refactored saving mechanic in ProfilesPanel which now doesn't
depend on

mechanic -> mechanics

> Source/WebCore/inspector/front-end/CPUProfileView.js:96
> +	   this._processProfileData(this.profileHeader._profile);

Can you add a note that this can happen only when the profile is loaded from
file?

> Source/WebCore/inspector/front-end/CPUProfileView.js:779
> + * @implements {WebInspector.OutputStreamDelegate}

This is weird, the same class is stream and delegate?

> Source/WebCore/inspector/front-end/CPUProfileView.js:816
> +    onError: function(reader, event) { },

Can we print something to the console?

> Source/WebCore/inspector/front-end/CPUProfileView.js:826
> +    close: function() { },

{} on separate lines

> Source/WebCore/inspector/front-end/CPUProfileView.js:870
> +		   // Profiling was tentatively terminated with the "Clear all
profiles." button.

tentatively ?