[webkit-reviews] review granted: [Bug 110926] Can't use fastGetAttribute with WebCore::HTMLNames::classAttr when element is a SVGStyledElement : [Attachment 196057] Patch

Mon Apr 1 20:01:29 PDT 2013

Ryosuke Niwa <rniwa at webkit.org> has granted Tim 'mithro' Ansell
<mithro at mithis.com>'s request for review:
Bug 110926: Can't use fastGetAttribute with WebCore::HTMLNames::classAttr when
element is a SVGStyledElement
https://bugs.webkit.org/show_bug.cgi?id=110926

Attachment 196057: Patch
https://bugs.webkit.org/attachment.cgi?id=196057&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196057&action=review

> Source/WebCore/ChangeLog:3
> +	   Use fastGetAttribute for className on HTML nodes but not SVG nodes.

This line should match the but title.

> Source/WebCore/ChangeLog:12
> +	   Reviewed by NOBODY (OOPS!).

This line should appear before the long description but after the bug URL.

> LayoutTests/dom/svg/svg-className-lookup-crash.htm:1
> +<body>

Missing DOCTYPE.

> LayoutTests/dom/svg/svg-className-lookup-crash.htm:13
> +  window.testRunner.dumpAsText();

Nit: This should be indented by 4 spaces, not 2.