[webkit-reviews] review denied: [Bug 113522] [Qt] Enable text tracks from track elements : [Attachment 196000] Patch

[bugzilla-daemon at webkit.org]

Allan Sandfeld Jensen <allan.jensen at digia.com> has denied Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 113522: [Qt] Enable text tracks from track elements
https://bugs.webkit.org/show_bug.cgi?id=113522

Attachment 196000: Patch
https://bugs.webkit.org/attachment.cgi?id=196000&action=review

------- Additional Comments from Allan Sandfeld Jensen <allan.jensen at digia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=196000&action=review


> Source/WebCore/ChangeLog:5
> +	   Enable text tracks in QtWebKit.
> +
> +	   [Qt] Enable text tracks from track elements

Please drop the first line and let the bug title be the commit subject.

> Source/WebCore/ChangeLog:10
> +	   No new tests because they're already there. This just enables the
feature.

Could you unskip the tests in LayoutTests/platform/qt/TestExpectations then?

> Tools/qmake/mkspecs/features/features.pri:120
> -    ENABLE_VIDEO_TRACK=0 \
> +    ENABLE_VIDEO_TRACK=1 \

What happens when VIDEO_TRACK is enabled and HTML5 video or GStreamer isn't?