[webkit-reviews] review denied: [Bug 113517] Simplify ContainerNode::removeChildren : [Attachment 196028] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 1 16:08:54 PDT 2013
Eric Seidel (vacation until 4/3) <eric at webkit.org> has denied Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 113517: Simplify ContainerNode::removeChildren
https://bugs.webkit.org/show_bug.cgi?id=113517
Attachment 196028: Patch
https://bugs.webkit.org/attachment.cgi?id=196028&action=review
------- Additional Comments from Eric Seidel (vacation until 4/3)
<eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=196028&action=review
> Source/WebCore/ChangeLog:12
> + Simplify ContainerNode::removeChildren by merging the loops and
removing
> + willRemoveChildren. This removes two traversals of the children,
avoids
> + refing and derefing all the children once, avoids allocating a
second
> + NodeVector of children, and means we detach() in the same order as
> + normal removal.
This observably changes behavior of mutation events. You should explain that
in your changelog, and ideally test the change.
> LayoutTests/fast/dom/containerNode.html:-2
> -<!DOCTYPE html>
> -<html>
Missing a ChangeLOg for this. Why are you removing this? --update-changelogs
passed to upload will add one for you. :)
More information about the webkit-reviews
mailing list