[webkit-reviews] review denied: [Bug 108897] [Cairo] Canvas-shadow behavior is not being as expected : [Attachment 195942] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Rashmi Shyamasundar
<rashmi.s2 at samsung.com>'s request for review:
Bug 108897: [Cairo] Canvas-shadow behavior is not being as expected
https://bugs.webkit.org/show_bug.cgi?id=108897

Attachment 195942: Patch
https://bugs.webkit.org/attachment.cgi?id=195942&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195942&action=review


No clue about the patch's correctness, but the ChangeLog is not good enough.

> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

You should remove this line; No ChangeLog with "OOPS" should land.

> Source/WebCore/ChangeLog:11
> +	   In PlatformContextCairo::drawSurfaceToContext(), 
> +	   extend mode for the pattern should be CAIRO_EXTEND_NONE

It is not enough explaining what you did, you have to explain why you are doing
the change:

You need to explain why the code was wrong, what errors it was causing, and why
the new code is correct.