[webkit-reviews] review granted: [Bug 113600] [CSS Exclusions] shape-outside on floats fails to respect shape-margin's vertical extent : [Attachment 195835] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 113600: [CSS Exclusions] shape-outside on floats fails to respect
shape-margin's vertical extent
https://bugs.webkit.org/show_bug.cgi?id=113600

Attachment 195835: Patch
https://bugs.webkit.org/attachment.cgi?id=195835&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195835&action=review


LGTM. Just some snippets.

> Source/WebCore/ChangeLog:9
> +	   ExclusionShapeOutsideInfo classes should depend on the
ExclusionShape's margin boundary.  Added

"boundary. A" unnecessary whitespace.

> Source/WebCore/rendering/ExclusionShapeInsideInfo.h:101
> +    virtual FloatRect computedShapeLogicalBoundingBox() const { return
computedShape()->shapePaddingLogicalBoundingBox(); }

Add OVERRIDE makro at the end.

> Source/WebCore/rendering/ExclusionShapeOutsideInfo.h:55
> +    virtual FloatRect computedShapeLogicalBoundingBox() const { return
computedShape()->shapeMarginLogicalBoundingBox(); }

Ditto.