[webkit-reviews] review denied: [Bug 113362] [Custom Elements]: document.register doesn't upgrade nodes in document above the registering script tag : [Attachment 195934] Addressed Adam's points

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hajime Morrita
<morrita at google.com>'s request for review:
Bug 113362: [Custom Elements]: document.register doesn't upgrade nodes in
document above the registering script tag
https://bugs.webkit.org/show_bug.cgi?id=113362

Attachment 195934: Addressed Adam's points
https://bugs.webkit.org/attachment.cgi?id=195934&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195934&action=review


This is starting to come together. I am still not super-sure about the extra
flag, but this discussion is progressing nicely on W3C bug.

> Source/WebCore/dom/CustomElementRegistry.h:61
> +	   CreatedCallback,

NeedsReadyCallback?

> Source/WebCore/dom/CustomElementRegistry.h:62
> +	   Upgrade

NeedsUpgrade?

> Source/WebCore/dom/CustomElementRegistry.h:113
> +    void didBecomeCustomElement(Element*, CustomElementConstructor*);

didUpgradeElement?

> Source/WebCore/dom/Element.h:598
> +#if ENABLE(DIALOG_ELEMENT)

CUSTOM_ELEMENTS?

> Source/WebCore/dom/ElementRareData.h:205
> +#if ENABLE(DIALOG_ELEMENT)

CUSTOM_ELEMENTS?