[webkit-reviews] review granted: [Bug 103927] [Resource Timing] Expose timing information for iframes : [Attachment 195815] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 1 09:48:35 PDT 2013
Nate Chapin <japhet at chromium.org> has granted James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 103927: [Resource Timing] Expose timing information for iframes
https://bugs.webkit.org/show_bug.cgi?id=103927
Attachment 195815: Patch
https://bugs.webkit.org/attachment.cgi?id=195815&action=review
------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195815&action=review
> Source/WebCore/loader/cache/CachedResourceLoader.cpp:535
> + if (frame()->ownerElement() &&
m_documentLoader->frameLoader()->stateMachine()->committingFirstRealLoad()) {
> + InitiatorInfo info = { frame()->ownerElement()->localName(),
monotonicallyIncreasingTime() };
> + m_initiatorMap.add(newResource.get(), info);
> + }
This probably needs a comment, maybe a link to the spec?
More information about the webkit-reviews
mailing list