[webkit-reviews] review granted: [Bug 111342] table element may get larger when its contents are recreated : [Attachment 195958] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 111342: table element may get larger when its contents are recreated
https://bugs.webkit.org/show_bug.cgi?id=111342

Attachment 195958: Patch
https://bugs.webkit.org/attachment.cgi?id=195958&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=195958&action=review


> LayoutTests/fast/table/anonymous-table-section-removed-expected.txt:2
> +PASS

check-layout.js is annoyingly terse; sure would be nice to say more than just
PASS

> LayoutTests/fast/table/anonymous-table-section-removed.html:9
> +	   document.body.offsetHeight;

Irritating that we don’t have a more natural way to force layout. I know we
rely on this a lot in tons of tests, but I’d rather have it be through a
function so we can fix it in one place if we have to. Some day we might want to
optimize calls to get property values that don’t examine the function result
;-)

> LayoutTests/fast/table/anonymous-table-section-removed.html:14
> +    checkLayout('table')

A little strange to omit the semicolon here.