[webkit-reviews] review denied: [Bug 110921] Web Inspector: allow referencing of nodes that have not been pushed to the front-end : [Attachment 195968] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 110921: Web Inspector: allow referencing of nodes that have not been pushed
to the front-end
https://bugs.webkit.org/show_bug.cgi?id=110921

Attachment 195968: Patch
https://bugs.webkit.org/attachment.cgi?id=195968&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195968&action=review


> Source/WebCore/inspector/Inspector.json:2022
> +		   "name": "releaseBackendIdsForNodeGroup",

releaseBackendNodeIds

> Source/WebCore/inspector/InspectorDOMAgent.cpp:616
> +	   m_nodeGroupToBackendIdMap.set(nodeGroup, NodeToBackendIdMap());

You don't need this, object will be created automatically upon access.

> Source/WebCore/inspector/InspectorDOMAgent.cpp:619
> +    BackendNodeId id = map.get(node);

id = m_nodeGroupToBackendIdMap[nodeGroup].get(node);

> Source/WebCore/inspector/InspectorDOMAgent.cpp:623
> +	   m_backendIdToNode.set(id, std::make_pair(node, nodeGroup));

m_nodeGroupToBackendIdMap[nodeGroup].set(id, ...);

> Source/WebCore/inspector/InspectorDOMAgent.cpp:632
> +	   NodeToBackendIdMap& map =
*m_nodeGroupToBackendIdMap.find(nodeGroup).values();

ditto