[webkit-reviews] review denied: [Bug 110921] Web Inspector: allow referencing of nodes that have not been pushed to the front-end : [Attachment 195749] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Dmitry Gozman
<dgozman at chromium.org>'s request for review:
Bug 110921: Web Inspector: allow referencing of nodes that have not been pushed
to the front-end
https://bugs.webkit.org/show_bug.cgi?id=110921

Attachment 195749: Patch
https://bugs.webkit.org/attachment.cgi?id=195749&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195749&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:631
> +void InspectorDOMAgent::releaseBackendIdsForNodeGroup(const String&
nodeGroup)

This method should be exposed via the protocol.

> Source/WebCore/inspector/InspectorDOMAgent.h:250
> +    HashMap<String, OwnPtr<NodeToBackendIdMap> > m_nodeGroupToBackendIdMap;

Lets store by value instead.