[webkit-reviews] review denied: [Bug 113696] Web Inspector: [Network] dataURIs are listed as separate requests in HAR. : [Attachment 195952] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 1 05:09:39 PDT 2013
Pavel Feldman <pfeldman at chromium.org> has denied Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 113696: Web Inspector: [Network] dataURIs are listed as separate requests
in HAR.
https://bugs.webkit.org/show_bug.cgi?id=113696
Attachment 195952: Patch
https://bugs.webkit.org/attachment.cgi?id=195952&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=195952&action=review
> Source/WebCore/inspector/front-end/NetworkPanel.js:1150
> + return request.parsedURL.isValid;
You should explicitly check for data url.
Btw, do we really want to see data urls in the network panel by default?
A test?
More information about the webkit-reviews
mailing list