[webkit-reviews] review denied: [Bug 113433] ContainerNode::removeChildren should first detach the children then remove them : [Attachment 195951] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Andrei Bucur <abucur at adobe.com>'s
request for review:
Bug 113433: ContainerNode::removeChildren should first detach the children then
remove them
https://bugs.webkit.org/show_bug.cgi?id=113433

Attachment 195951: Patch
https://bugs.webkit.org/attachment.cgi?id=195951&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=195951&action=review


> Source/WebCore/dom/ContainerNode.cpp:459
> +static void willRemoveChildren(ContainerNode* container, NodeVector&
children)

This function has unclear purpose (doing both pre-removal tasks and building up
the child vector). I think it would be better to pass in an initialized child
vector and possibly rename the function to something more descriptive (though I
don't have great suggestions, fireEventsBeforeRemovingAllChildren or
something).