[webkit-reviews] review granted: [Bug 113681] Remove a couple of malloc from ExceptionBase construction : [Attachment 195931] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 1 01:14:52 PDT 2013


Darin Adler <darin at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 113681: Remove a couple of malloc from ExceptionBase construction
https://bugs.webkit.org/show_bug.cgi?id=113681

Attachment 195931: Patch
https://bugs.webkit.org/attachment.cgi?id=195931&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good. We also need to fix this so we don’t need to use String::number in
cases like this; should format the number into a temporary buffer that can then
be appended to the string, not a heap-allocated string.


More information about the webkit-reviews mailing list