[webkit-reviews] review denied: [Bug 97964] Web Inspector: NMI make String* instrumentation non intrusive : [Attachment 166364] fix for KURL

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 97964: Web Inspector: NMI make String* instrumentation non intrusive
https://bugs.webkit.org/show_bug.cgi?id=97964

Attachment 166364: fix for KURL
https://bugs.webkit.org/attachment.cgi?id=166364&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166364&action=review


> Source/WTF/wtf/MemoryInstrumentationString.h:46
> +    if (stringImpl->usesInternalBuffer() &&
!stringImpl->hasTerminatingNullCharacter())

It doesn't seem to work for BufferOwned type of character buffer
ownership(everything created with StringImpl::adopt). Please fix that and
provide a test for that case.

> Source/WebKit/chromium/tests/MemoryInstrumentationTest.cpp:277
>      }

Pleas add a test for substring and for a regular string without shadow.