[webkit-reviews] review denied: [Bug 97175] Duplicate render objects should be removed when anonymous blocks are removed. : [Attachment 166130] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 97175: Duplicate render objects should be removed when anonymous blocks are
removed.
https://bugs.webkit.org/show_bug.cgi?id=97175

Attachment 166130: Patch
https://bugs.webkit.org/attachment.cgi?id=166130&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
Looking more this looks really complicated and will not cover all the cases. if
we just remove the block that splits the inline, then we will still have this
problem. [try <i>A<div id=div1>B</div>C</i> and then do
document.body.offsetTop; div1.parentNode.removeChild(div1).] When the div is
removed, the renderinline and its continuation should be merged and both A and
C should be under one RenderInline. Your patch only covers the moving case and
in the example above, we are not moving any children between the inline and its
continuation. Also, your patch makes the things slow since stuff gets moved
between prev and next much more often. What you probably need to do is see
about hooking stuff near the ->setContinuation calls added in 
http://trac.webkit.org/changeset/120477. We already cleanup the empty block
continuation there.