[webkit-reviews] review granted: [Bug 97893] REGRESSION(r127727): Calendar picker is ignoring step : [Attachment 166406] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Sep 30 22:05:48 PDT 2012
Kent Tamura <tkent at chromium.org> has granted Keishi Hattori
<keishi at webkit.org>'s request for review:
Bug 97893: REGRESSION(r127727): Calendar picker is ignoring step
https://bugs.webkit.org/show_bug.cgi?id=97893
Attachment 166406: Patch
https://bugs.webkit.org/attachment.cgi?id=166406&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166406&action=review
> Source/WebCore/ChangeLog:8
> + There were two mistakes. If statement was wrong and
DateTimeChooserParameters.step was number of milliseconds when it should be
number of days.
"If statement was ..." is a very confusing sentence. should be "An
if-statement was ..."
Also, bulletizing improves readability. e.g.
There were two mistakes:
- An if-statement to check step attribute validity was wrong, and
- DateTiemChooserParameters.step was milleseconds when it should be number of
days.
More information about the webkit-reviews
mailing list