[webkit-reviews] review denied: [Bug 96844] Sign in front of keyframe selector causes the subsequent ruleset to be ignored : [Attachment 166375] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 29 22:02:18 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Glenn Adams
<glenn at skynav.com>'s request for review:
Bug 96844: Sign in front of keyframe selector causes the subsequent ruleset to
be ignored
https://bugs.webkit.org/show_bug.cgi?id=96844

Attachment 166375: Patch
https://bugs.webkit.org/attachment.cgi?id=166375&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166375&action=review


> Source/WebCore/ChangeLog:8
> +	   Upon encountering negative percentage, ignore only subsequent block.


I don't think we should ignore the block at the parsing level. This is totally
valid CSS; we just need to handle keyframes outside of 0-100% in the code.


More information about the webkit-reviews mailing list