[webkit-reviews] review granted: [Bug 96286] Another SIGILL in JavaScriptCore on a Geode processor : [Attachment 166363] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Daniel Drake <dsd at laptop.org>'s
request for review:
Bug 96286: Another SIGILL in JavaScriptCore on a Geode processor
https://bugs.webkit.org/show_bug.cgi?id=96286

Attachment 166363: Patch
https://bugs.webkit.org/attachment.cgi?id=166363&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
The usual style we use for disabling something is to use

#define ENABLE_LLINT 0

And put it before the logic that enables it. You'll notice that the logic that
enables it checks if the macro is already defined, and if so, does nothing. I
think this is less fragile, and should be easier to grok since we already do
this in other places.