[webkit-reviews] review granted: [Bug 97925] virtual directories should just rename the beginning of the test path : [Attachment 166290] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 97925: virtual directories should just rename the beginning of the test
path
https://bugs.webkit.org/show_bug.cgi?id=97925

Attachment 166290: Patch
https://bugs.webkit.org/attachment.cgi?id=166290&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166290&action=review


Thanks for the quick fix!

> Tools/Scripts/webkitpy/layout_tests/port/test.py:244
> +    tests.add('passes/test-virtual-passes.html')

Nit: For good measure, how about "passes/passes/test-virtual-passes.html"? You
could imagine future code trying to be clever and rename directories and
accidentally renaming both directories.

> LayoutTests/platform/chromium/TestExpectations:2485
> +webkit.org/b/84900
platform/chromium/virtual/softwarecompositing/regions/webkit-flow-renderer-laye
r-compositing.html [ Skip ]

Can unskip this now and make an ImageOnlyFailure