[webkit-reviews] review granted: [Bug 97926] Garden-o-matic sometimes thinks buildbot warnings are failures : [Attachment 166289] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 97926: Garden-o-matic sometimes thinks buildbot warnings are failures
https://bugs.webkit.org/show_bug.cgi?id=97926

Attachment 166289: Patch
https://bugs.webkit.org/attachment.cgi?id=166289&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166289&action=review


> Tools/ChangeLog:3
> +	   Garden-o-matic sometimes things buildbot warnings are failures

things -> thinks

> Tools/ChangeLog:9
> +	   It turns out the JSON clearly tells us if it's a failure. We don't
need to
> +	   search the text for the word "warning" and hope it's right.

I would reword this to make it clear that we want to ignore all warnings.