[webkit-reviews] review granted: [Bug 97706] Scroll offset of flex items lost during relayout : [Attachment 166249] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 97706: Scroll offset of flex items lost during relayout
https://bugs.webkit.org/show_bug.cgi?id=97706

Attachment 166249: Patch
https://bugs.webkit.org/attachment.cgi?id=166249&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166249&action=review


> Source/WebCore/rendering/RenderBlock.cpp:1359
> +	   if (style()->isFlippedBlocksWritingMode()) {
> +	       // FIXME: Workaround for now. We cannot delay the scroll info
for overflow for

We should file a bug about this (losing scroll position when using
horizontal-bt or vertical-rl layout).  It would probably be possible to move
the code that scrolls a bt or rl layer or maybe make an exception for it.  I'm
not sure where that code is, but I bet we could make this work without too much
effort.  Seems fine to fix in a separate patch.