[webkit-reviews] review denied: [Bug 97903] Make RenderLayerCompositor::requiresCompositingForScrollableFrame scrollbars agnostic : [Attachment 166272] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Antonio Gomes
<tonikitoo at webkit.org>'s request for review:
Bug 97903: Make RenderLayerCompositor::requiresCompositingForScrollableFrame
scrollbars agnostic
https://bugs.webkit.org/show_bug.cgi?id=97903

Attachment 166272: patch
https://bugs.webkit.org/attachment.cgi?id=166272&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166272&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:1675
> +    // FIXME: Make FrameView::parentFrameView public to simplify this.
> +    if (!view->parent() || !view->parent()->isFrameView())
> +	   return false;
> +
> +    m_reevaluateCompositingAfterLayout = true;
> +
> +    return
static_cast<FrameView*>(view->parent())->containsScrollableArea(view);

I don't get why this is any better, or why it makes sense to ask our parent if
it contains us?

Why not just invent a way to ask about scrollability that doesn't involve
scrollbars?