[webkit-reviews] review granted: [Bug 97922] [BlackBerry] Extend composited in-region scrolling to iframes/frames : [Attachment 166268] patch

[bugzilla-daemon at webkit.org]

Yong Li <yoli at rim.com> has granted Antonio Gomes <tonikitoo at webkit.org>'s
request for review:
Bug 97922: [BlackBerry] Extend composited  in-region scrolling to
iframes/frames
https://bugs.webkit.org/show_bug.cgi?id=97922

Attachment 166268: patch
https://bugs.webkit.org/attachment.cgi?id=166268&action=review

------- Additional Comments from Yong Li <yoli at rim.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166268&action=review


r+ with some comments

> Source/WebKit/blackberry/Api/InRegionScroller.cpp:154
> +	       if (scrollTarget == Platform::ScrollViewBase::BlockElement) {
> +		   RenderLayerBacking* backing =
static_cast<RenderLayerBacking*>(graphicsLayer->client());
> +		   layer = backing->owningLayer();
> +	       } else {
> +		   RenderLayerCompositor* compositor =
static_cast<RenderLayerCompositor*>(graphicsLayer->client());
> +		   layer = compositor->rootRenderLayer();
> +	       }

static_cast<> worries me. Is it possible to add something to
GraphicsLayerClient?

> Source/WebKit/blackberry/Api/InRegionScroller.h:41
> +    bool setScrollPositionWebKitThread(unsigned camouflagedLayer, const
Platform::IntPoint& /*scrollPosition*/,
> +	   bool /*acceleratedScrolling*/,
Platform::ScrollViewBase::ScrollTarget);

why are we using /* */ here?