[webkit-reviews] review granted: [Bug 97703] [V8] Make v8NPObjectMap per Context : [Attachment 166258] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Fady Samuel <fsamuel at chromium.org>'s
request for review:
Bug 97703: [V8] Make v8NPObjectMap per Context
https://bugs.webkit.org/show_bug.cgi?id=97703

Attachment 166258: Patch
https://bugs.webkit.org/attachment.cgi?id=166258&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166258&action=review


This looks great.  I don't have a complete enough understanding of how plugins
work to know if this is going to work in all cases, but I think we should give
it a try.

> Source/WebCore/bindings/v8/NPV8Object.cpp:79
> +	   V8NPObjectMap* v8NPObjectMap = perContextData->getV8NPObjectMap();

getV8NPObjectMap -> v8NPObjectMap

We tend to avoid the "get" prefix in names because it doesn't really mean
anything.