[webkit-reviews] review granted: [Bug 97807] [Chromium] Fix the find-in-page implementation for detaching frames. : [Attachment 166213] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Leandro Graciá Gil
<leandrogracia at chromium.org>'s request for review:
Bug 97807: [Chromium] Fix the find-in-page implementation for detaching frames.
https://bugs.webkit.org/show_bug.cgi?id=97807

Attachment 166213: Patch
https://bugs.webkit.org/attachment.cgi?id=166213&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166213&action=review


Thanks for improving the test.

> Source/WebKit/chromium/src/WebFrameImpl.cpp:2332
> +    m_frame = frame;
> +    observeFrame(m_frame);

m_frame is now almost redundant.  FrameDestructionObserver also has a m_frame
pointer.  It might be worth adding a FIXME comment about removing m_frame.