[webkit-reviews] review granted: [Bug 97885] Add parseDateTime, formatDateTime, and dateFormatText to Localizer : [Attachment 166203] Patch 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 28 06:27:14 PDT 2012
Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 97885: Add parseDateTime, formatDateTime, and dateFormatText to Localizer
https://bugs.webkit.org/show_bug.cgi?id=97885
Attachment 166203: Patch 2
https://bugs.webkit.org/attachment.cgi?id=166203&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166203&action=review
Looks OK.
> Source/WebCore/platform/text/LocaleNone.cpp:71
> + return ASCIILiteral("Year-Month-Day");
I'm not sure if this should be ASCIILiteral("Year-Month-Day") or String().
More information about the webkit-reviews
mailing list