[webkit-reviews] review granted: [Bug 97409] [Chromium] Incorrect resampling of clipped/masked images. : [Attachment 165299] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 28 05:50:44 PDT 2012
Stephen White <senorblanco at chromium.org> has granted Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 97409: [Chromium] Incorrect resampling of clipped/masked images.
https://bugs.webkit.org/show_bug.cgi?id=97409
Attachment 165299: Patch
https://bugs.webkit.org/attachment.cgi?id=165299&action=review
------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165299&action=review
Looks good. r=me
> Source/WebCore/platform/graphics/skia/ImageSkia.cpp:208
> + subsetTransform.reset();
> +
subsetTransform.setScale(SkScalarAbs(canvas.getTotalMatrix().getScaleX()),
> +
SkScalarAbs(canvas.getTotalMatrix().getScaleY()));
Nit: I don't think you need to reset() if you immediately setScale().
More information about the webkit-reviews
mailing list