[webkit-reviews] review granted: [Bug 97799] Web Inspector: [Device Metrics] Remove the gutter overlay moving its functionality into the InspectorOverlay : [Attachment 166193] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 97799: Web Inspector: [Device Metrics] Remove the gutter overlay moving its
functionality into the InspectorOverlay
https://bugs.webkit.org/show_bug.cgi?id=97799

Attachment 166193: Patch
https://bugs.webkit.org/attachment.cgi?id=166193&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166193&action=review


> Source/WebCore/inspector/InspectorOverlay.cpp:240
> +void InspectorOverlay::webViewResized(const IntSize& size)

resize

> Source/WebCore/inspector/InspectorOverlay.cpp:242
> +    m_webViewSize = size;

m_size

> Source/WebCore/inspector/InspectorOverlay.cpp:296
> +    reset(visibleRect.size());

Lets pass both size and frameViewSize here.

> Source/WebCore/inspector/InspectorOverlay.cpp:299
> +    drawGutters(m_webViewSize.isEmpty() ? IntSize() : frameViewFullSize);

Pass nothing here.

> Source/WebCore/inspector/InspectorOverlayPage.html:289
> +    var frameWidth = gutterData.frameWidth;

window.frameViewSize.width

> Source/WebCore/inspector/InspectorOverlayPage.html:293
> +	   rightGutter.style.display = "";

rightGutter.style.removeProperty("display")