[webkit-reviews] review requested: [Bug 89742] [Win] key event's location does not work on Windows platform. : [Attachment 162416] Patch

[bugzilla-daemon at webkit.org]

Takashi Sakamoto <tasak at google.com> has asked  for review:
Bug 89742: [Win] key event's location does not work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=89742

Attachment 162416: Patch
https://bugs.webkit.org/attachment.cgi?id=162416&action=review

------- Additional Comments from Takashi Sakamoto <tasak at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=162416&action=review


Thank you for reviewing.

>> Source/WebCore/ChangeLog:9
>> +	    directly provide a virtual keycode which distinguish between
left-hand
> 
> These two lines of changelogs are messed up.

Done.

>> Source/WebCore/platform/win/KeyEventWin.cpp:196
>> +	// the right-hand ALT and CTRL keys.
> 
> This is quite obvious from the code.

Done.

>> Source/WebCore/platform/win/KeyEventWin.cpp:197
>> +	// However, if we don't need to support WindowsXP or older Windows,
> 
> Nit: Windows XP.

Done.