[webkit-reviews] review granted: [Bug 97864] [Forms] Adding DateTimeMonthFieldElement and DateTimeYearFieldElement : [Attachment 166153] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 97864: [Forms] Adding DateTimeMonthFieldElement and
DateTimeYearFieldElement
https://bugs.webkit.org/show_bug.cgi?id=97864

Attachment 166153: Patch 1
https://bugs.webkit.org/attachment.cgi?id=166153&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166153&action=review


> Source/WebCore/ChangeLog:26
> +	   Note: This patch affects ports which enable both
ENABLE_INPUT_TYPE_TIME
> +	   and ENABLE_INPUT_MULTIPLE_FIELDS_UI.

Looks wrong.  INPUT_TYPE_TIME is unrelated.

> Source/WebCore/ChangeLog:52
> +	   (WebCore::DateTimeNumericFieldElement::stepDown): Changed to use
defaultValueForStepDown instead of maximum field value.
> +	   (WebCore::DateTimeNumericFieldElement::stepUp):  Changed to use
defaultValueForStepUp minium field value.
> +	   (WebCore::DateTimeNumericFieldElement::value): Changed to use "%04d"
when maximum field value is greater than 999 for year field.

They should be "why" comments.	"what" comments are not helpful in many cases.