[webkit-reviews] review granted: [Bug 97173] [EFL][WK2] Refactoring initialization and shutdown codes of EFL libraries. : [Attachment 165999] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 27 23:16:40 PDT 2012
Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 97173: [EFL][WK2] Refactoring initialization and shutdown codes of EFL
libraries.
https://bugs.webkit.org/show_bug.cgi?id=97173
Attachment 165999: Patch
https://bugs.webkit.org/attachment.cgi?id=165999&action=review
------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=165999&action=review
> Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:42
> + * @internal
It would be good to add a new line @internal below,
> Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:107
> + * @internal
ditto.
> Source/WebKit2/UIProcess/API/efl/ewk_main.cpp:109
> + * If the reference count reaches 0 WebKit's instance is destroyed.
reaches 0 -> reaches 0, ?
More information about the webkit-reviews
mailing list