[webkit-reviews] review granted: [Bug 97474] [Chromium] Remove screen-related functions from PlatformSupport : [Attachment 166059] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Sep 27 14:23:09 PDT 2012
Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 97474: [Chromium] Remove screen-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=97474
Attachment 166059: Patch
https://bugs.webkit.org/attachment.cgi?id=166059&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166059&action=review
Very nice.
> Source/Platform/chromium/public/WebScreenInfo.h:77
> + , isMonochrome(false) { }
Technically the { and } should each be on their own line.
> Source/WebKit/chromium/src/ChromeClientImpl.cpp:911
> +
You've got an extra blank line here
More information about the webkit-reviews
mailing list