[webkit-reviews] review granted: [Bug 97794] IndexedDB: Optimize encodeString/decodeString : [Attachment 166028] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 97794: IndexedDB: Optimize encodeString/decodeString
https://bugs.webkit.org/show_bug.cgi?id=97794

Attachment 166028: Patch
https://bugs.webkit.org/attachment.cgi?id=166028&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=166028&action=review


> Source/WebCore/ChangeLog:9
> +	   Optimize string encoding/decoding, which showed up as a CPU hot spot
during profiling.
> +	   The backing store uses big-endian ordering of 16-bit code unit
strings, so a memcopy

Nit: It would be nice to include some perf numbers.

> Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp:29
> +// for htons/ntohs

Nit: Capitalize and end with a period.