[webkit-reviews] review granted: [Bug 95360] requestAnimationFrame broken with subframes (DisplayRefreshMonitorManager::registerClient fails to register client) : [Attachment 166058] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 27 13:57:52 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Andrew Lo
<anlo at rim.com>'s request for review:
Bug 95360: requestAnimationFrame broken with subframes
(DisplayRefreshMonitorManager::registerClient fails to register client)
https://bugs.webkit.org/show_bug.cgi?id=95360

Attachment 166058: Patch
https://bugs.webkit.org/attachment.cgi?id=166058&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=166058&action=review


> LayoutTests/fast/animation/request-animation-frame-iframe2.html:23
> +	   window.webkitRequestAnimationFrame(function() {
> +	       mainFrameCallbackInvoked = true;
> +	   }, e);

requestAnimationFrame() does not take an element parameter. That subframe JS
should be fixed too.


More information about the webkit-reviews mailing list