[webkit-reviews] review granted: [Bug 97676] [Chromium] FontHarfBuzz.cpp should not use drawTextOnPath() : [Attachment 165993] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 97676: [Chromium] FontHarfBuzz.cpp should not use drawTextOnPath()
https://bugs.webkit.org/show_bug.cgi?id=97676

Attachment 165993: Patch
https://bugs.webkit.org/attachment.cgi?id=165993&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165993&action=review


The EWS bot failure looks real.

> Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp:100
> +	       canvas->drawTextOnPath(glyphs + i, 2, path, 0, paint);

Can we use sizeof(GlyphBufferGlyph) instead of hardcoding 2?

> Source/WebCore/platform/graphics/harfbuzz/FontHarfBuzz.cpp:121
> +	       canvas->drawTextOnPath(glyphs + i, 2, path, 0, paint);

Ditto.