[webkit-reviews] review granted: [Bug 96516] [Chromium] Move UNIX-specific theme functions out of PlatformSupport : [Attachment 165883] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 27 09:35:48 PDT 2012


Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 96516: [Chromium] Move UNIX-specific theme functions out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=96516

Attachment 165883: Patch
https://bugs.webkit.org/attachment.cgi?id=165883&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=165883&action=review


> Source/WebCore/platform/chromium/ScrollbarThemeChromiumLinux.cpp:112
> +    WebKit::Platform::current()->themeEngine()->paint(
> +	   canvas,
> +	   paintPart,
> +	   state,
> +	   WebKit::WebRect(rect),
> +	   0);

I would just put all this stuff on one line.  This line breaking style comes
from the Chromium style guide and is a result of the 80 col limit.

> Source/WebCore/rendering/RenderThemeChromiumAndroid.cpp:39
>  

No need for a blank line here.

> Source/WebCore/rendering/RenderThemeChromiumLinux.cpp:61
> +    {
> +	   if (!theme->isEnabled(o))
> +	       return WebKit::WebThemeEngine::StateDisabled;
> +	   if (theme->isPressed(o))
> +	       return WebKit::WebThemeEngine::StatePressed;

Looks like you've got a bad indent here.


More information about the webkit-reviews mailing list